summaryrefslogtreecommitdiff
path: root/roles/monitoring
diff options
context:
space:
mode:
authorChristian Pointner <equinox@spreadspace.org>2021-09-25 19:11:28 +0200
committerChristian Pointner <equinox@spreadspace.org>2021-09-25 19:11:57 +0200
commit4921bb0dc32811aa40cf07ec8ad83f6f197ada0e (patch)
tree1abceabc8a7922b97499bd18155c201c444caa53 /roles/monitoring
parentadd prometheus exporter IPMI (diff)
disabling smartmon textfile collector by default since this can lead to idempotence issues with systemd that don't have smartcl installed
Diffstat (limited to 'roles/monitoring')
-rw-r--r--roles/monitoring/prometheus/exporter/node/defaults/main.yml1
-rw-r--r--roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml3
-rw-r--r--roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j24
3 files changed, 3 insertions, 5 deletions
diff --git a/roles/monitoring/prometheus/exporter/node/defaults/main.yml b/roles/monitoring/prometheus/exporter/node/defaults/main.yml
index 870753c3..9309562f 100644
--- a/roles/monitoring/prometheus/exporter/node/defaults/main.yml
+++ b/roles/monitoring/prometheus/exporter/node/defaults/main.yml
@@ -14,4 +14,3 @@ prometheus_exporter_node_extra_collectors:
prometheus_exporter_node_textfile_collector_scripts:
- deleted-libraries
- - smartmon
diff --git a/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml b/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml
index 5c068fe7..80390a15 100644
--- a/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml
+++ b/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml
@@ -19,3 +19,6 @@
name: "prometheus-node-exporter_{{ textfile_collector_name }}.timer"
state: started
enabled: yes
+
+
+## TODO: install deps for textfile collectors: i.e. smartmontools for collector smartmon
diff --git a/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2 b/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2
index 438da6b0..576f5a9f 100644
--- a/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2
+++ b/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2
@@ -1,9 +1,5 @@
[Unit]
Description=Promethues node exporter textfile collector smartmon
-ConditionPathExists=/usr/sbin/smartctl
-ConditionPathExistsGlob=|/dev/sd*
-ConditionPathExistsGlob=|/dev/hd*
-ConditionPathExistsGlob=|/dev/nvme*
[Timer]
OnBootSec=30s