From 4921bb0dc32811aa40cf07ec8ad83f6f197ada0e Mon Sep 17 00:00:00 2001 From: Christian Pointner Date: Sat, 25 Sep 2021 19:11:28 +0200 Subject: disabling smartmon textfile collector by default since this can lead to idempotence issues with systemd that don't have smartcl installed --- roles/monitoring/prometheus/exporter/node/defaults/main.yml | 1 - .../prometheus/exporter/node/tasks/textfile_collector_script.yml | 3 +++ .../node/templates/textfile-collector-scripts/smartmon.timer.j2 | 4 ---- 3 files changed, 3 insertions(+), 5 deletions(-) (limited to 'roles/monitoring') diff --git a/roles/monitoring/prometheus/exporter/node/defaults/main.yml b/roles/monitoring/prometheus/exporter/node/defaults/main.yml index 870753c3..9309562f 100644 --- a/roles/monitoring/prometheus/exporter/node/defaults/main.yml +++ b/roles/monitoring/prometheus/exporter/node/defaults/main.yml @@ -14,4 +14,3 @@ prometheus_exporter_node_extra_collectors: prometheus_exporter_node_textfile_collector_scripts: - deleted-libraries - - smartmon diff --git a/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml b/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml index 5c068fe7..80390a15 100644 --- a/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml +++ b/roles/monitoring/prometheus/exporter/node/tasks/textfile_collector_script.yml @@ -19,3 +19,6 @@ name: "prometheus-node-exporter_{{ textfile_collector_name }}.timer" state: started enabled: yes + + +## TODO: install deps for textfile collectors: i.e. smartmontools for collector smartmon diff --git a/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2 b/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2 index 438da6b0..576f5a9f 100644 --- a/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2 +++ b/roles/monitoring/prometheus/exporter/node/templates/textfile-collector-scripts/smartmon.timer.j2 @@ -1,9 +1,5 @@ [Unit] Description=Promethues node exporter textfile collector smartmon -ConditionPathExists=/usr/sbin/smartctl -ConditionPathExistsGlob=|/dev/sd* -ConditionPathExistsGlob=|/dev/hd* -ConditionPathExistsGlob=|/dev/nvme* [Timer] OnBootSec=30s -- cgit v1.2.3