From a8e8cb2ed3d5e68d89edd8785ed59f0ee45f81bf Mon Sep 17 00:00:00 2001
From: Christian Pointner <equinox@spreadspace.org>
Date: Tue, 21 Sep 2021 19:34:25 +0200
Subject: prometheus: simplify job config

---
 .../server/templates/job-snippets/blackbox-https.j2     |  2 +-
 .../server/templates/job-snippets/blackbox-ping.j2      |  2 +-
 .../server/templates/job-snippets/blackbox-ssh.j2       |  2 +-
 .../prometheus/server/templates/job-snippets/generic.j2 |  2 +-
 .../prometheus/server/templates/job-snippets/nut-ups.j2 | 13 +++++++++++++
 .../prometheus/server/templates/job-snippets/openwrt.j2 |  2 +-
 .../prometheus/server/templates/prometheus.yml.j2       |  2 +-
 .../prometheus/server/templates/targets/generic.yml.j2  |  4 ++--
 .../prometheus/server/templates/targets/nut-ups.yml.j2  | 17 +++++++++++++++++
 .../prometheus/server/templates/targets/nut.yml.j2      | 17 -----------------
 10 files changed, 38 insertions(+), 25 deletions(-)
 create mode 100644 roles/monitoring/prometheus/server/templates/job-snippets/nut-ups.j2
 create mode 100644 roles/monitoring/prometheus/server/templates/targets/nut-ups.yml.j2
 delete mode 100644 roles/monitoring/prometheus/server/templates/targets/nut.yml.j2

(limited to 'roles/monitoring/prometheus/server/templates')

diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-https.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-https.j2
index 0a6d2dfa..98a64121 100644
--- a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-https.j2
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-https.j2
@@ -11,4 +11,4 @@
       key_file: /etc/ssl/prometheus/server/scrape-key.pem
     file_sd_configs:
     - files:
-      - "/etc/prometheus/jobs/{{ job }}/*.yml"
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ping.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ping.j2
index 7f4f12df..736ffec1 100644
--- a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ping.j2
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ping.j2
@@ -11,4 +11,4 @@
       key_file: /etc/ssl/prometheus/server/scrape-key.pem
     file_sd_configs:
     - files:
-      - "/etc/prometheus/jobs/{{ job }}/*.yml"
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ssh.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ssh.j2
index 18381e32..166f37ad 100644
--- a/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ssh.j2
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/blackbox-ssh.j2
@@ -11,4 +11,4 @@
       key_file: /etc/ssl/prometheus/server/scrape-key.pem
     file_sd_configs:
     - files:
-      - "/etc/prometheus/jobs/{{ job }}/*.yml"
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/generic.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/generic.j2
index 87992eeb..b155c5f7 100644
--- a/roles/monitoring/prometheus/server/templates/job-snippets/generic.j2
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/generic.j2
@@ -10,4 +10,4 @@
       key_file: /etc/ssl/prometheus/server/scrape-key.pem
     file_sd_configs:
     - files:
-      - "/etc/prometheus/jobs/{{ job }}/*.yml"
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/nut-ups.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/nut-ups.j2
new file mode 100644
index 00000000..3a2c5c62
--- /dev/null
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/nut-ups.j2
@@ -0,0 +1,13 @@
+  - job_name: '{{ job }}'
+    metrics_path: /proxy
+    params:
+      module:
+      - nut
+    scheme: https
+    tls_config:
+      ca_file: /etc/ssl/prometheus/ca-crt.pem
+      cert_file: /etc/ssl/prometheus/server/scrape-crt.pem
+      key_file: /etc/ssl/prometheus/server/scrape-key.pem
+    file_sd_configs:
+    - files:
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/job-snippets/openwrt.j2 b/roles/monitoring/prometheus/server/templates/job-snippets/openwrt.j2
index 493a4fdb..e93f8be7 100644
--- a/roles/monitoring/prometheus/server/templates/job-snippets/openwrt.j2
+++ b/roles/monitoring/prometheus/server/templates/job-snippets/openwrt.j2
@@ -2,4 +2,4 @@
     scheme: http
     file_sd_configs:
     - files:
-      - "/etc/prometheus/jobs/{{ job }}/*.yml"
+      - "/etc/prometheus/targets/{{ job }}/*.yml"
diff --git a/roles/monitoring/prometheus/server/templates/prometheus.yml.j2 b/roles/monitoring/prometheus/server/templates/prometheus.yml.j2
index 4cfcc498..3286bb82 100644
--- a/roles/monitoring/prometheus/server/templates/prometheus.yml.j2
+++ b/roles/monitoring/prometheus/server/templates/prometheus.yml.j2
@@ -35,7 +35,7 @@ scrape_configs:
     static_configs:
     - targets: ['{{ prometheus_server_alertmanager.url }}']
 {% endif %}
-{% for job in (prometheus_server_jobs_generic + prometheus_server_jobs_special) %}
+{% for job in (prometheus_server_jobs) %}
 
 {%   include 'job-snippets/' + (lookup('first_found', {'paths': ['templates/job-snippets'], 'files': [job + '.j2', 'generic.j2']}) | basename) %}{{ '' }}
 {% endfor %}
diff --git a/roles/monitoring/prometheus/server/templates/targets/generic.yml.j2 b/roles/monitoring/prometheus/server/templates/targets/generic.yml.j2
index e83b6bf4..45af10c0 100644
--- a/roles/monitoring/prometheus/server/templates/targets/generic.yml.j2
+++ b/roles/monitoring/prometheus/server/templates/targets/generic.yml.j2
@@ -1,3 +1,3 @@
-- targets: [ "{{ hostvars[target].prometheus_scrape_endpoint }}" ]
+- targets: [ "{{ hostvars[target.instance].prometheus_scrape_endpoint }}" ]
   labels:
-    instance: "{{ target }}"
+    instance: "{{ target.instance }}"
diff --git a/roles/monitoring/prometheus/server/templates/targets/nut-ups.yml.j2 b/roles/monitoring/prometheus/server/templates/targets/nut-ups.yml.j2
new file mode 100644
index 00000000..da3de3d7
--- /dev/null
+++ b/roles/monitoring/prometheus/server/templates/targets/nut-ups.yml.j2
@@ -0,0 +1,17 @@
+- targets: [ "{{ hostvars[target.config.exporter_hostname].prometheus_scrape_endpoint }}" ]
+  labels:
+    instance: "{{ target.instance }}"
+    __param_ups: {{ target.config.ups }}
+    __param_server: {{ target.config.server | default('127.0.0.1') }}
+{% if 'username' in target.config %}
+    __param_username: {{ target.config.username }}
+{% endif  %}
+{% if 'password' in target.config %}
+    __param_password: {{ target.config.password }}
+{% endif  %}
+{% if 'variables' in target.config %}
+    __param_variables: {{ target.config.variables }}
+{% endif  %}
+{% if 'statuses' in target.config %}
+    __param_statuses: {{ target.config.statuses }}
+{% endif  %}
diff --git a/roles/monitoring/prometheus/server/templates/targets/nut.yml.j2 b/roles/monitoring/prometheus/server/templates/targets/nut.yml.j2
deleted file mode 100644
index da3de3d7..00000000
--- a/roles/monitoring/prometheus/server/templates/targets/nut.yml.j2
+++ /dev/null
@@ -1,17 +0,0 @@
-- targets: [ "{{ hostvars[target.config.exporter_hostname].prometheus_scrape_endpoint }}" ]
-  labels:
-    instance: "{{ target.instance }}"
-    __param_ups: {{ target.config.ups }}
-    __param_server: {{ target.config.server | default('127.0.0.1') }}
-{% if 'username' in target.config %}
-    __param_username: {{ target.config.username }}
-{% endif  %}
-{% if 'password' in target.config %}
-    __param_password: {{ target.config.password }}
-{% endif  %}
-{% if 'variables' in target.config %}
-    __param_variables: {{ target.config.variables }}
-{% endif  %}
-{% if 'statuses' in target.config %}
-    __param_statuses: {{ target.config.statuses }}
-{% endif  %}
-- 
cgit v1.2.3